Opened on 02/04/2015 at 12:45:27 PM

Last modified on 03/16/2015 at 12:00:27 PM

#1937 new change

Clean WBPassthruSink

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

Description

Background

  • There are WBPassthruSink::m_contentType and WBPassthruSink::m_boundDomain which we don't need to have as members anymore.
  • Methods WBPassthruSink::GetContentTypeFromMimeType, WBPassthruSink::GetContentTypeFromURL, and WBPassthruSink::GetContentType are referenced only from cpp file and they don't access any protected member of WBPassthruSink, thus we don't need to have them as members.

What to change

  • remove WBPassthruSink::m_contentType and WBPassthruSink::m_boundDomain and declare them in the function where they are used.
  • move WBPassthruSink::GetContentTypeFromMimeType, WBPassthruSink::GetContentTypeFromURL, and WBPassthruSink::GetContentType into anonymous namespace in cpp file.

Attachments (0)

Change History (1)

comment:1 Changed on 03/16/2015 at 12:00:27 PM by oleksandr

  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P4
  • Ready set

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.