Opened on 02/05/2015 at 02:16:34 PM
Closed on 08/29/2019 at 05:43:52 PM
#1951 closed change (rejected)
new notification trigger mechanism based on ad counter
| Reported by: | annlee@adblockplus.org | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sebastian, wspee | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by annlee@adblockplus.org)
Background
There are many relevant messages which could be shown when the ad counter passes a certain number threshold, for example:
You've blocked 50,000 ads! If you're happy with this, please rate us.
You've blocked 50,000 ads! Help a friend do the same.
You've blocked 50,000 ads! Want to block more than just ads? Check out extra blocking features on our Options page.
However, there are currently only trigger mechanisms based on extension version, application, platform. Therefore, this is a request for a new trigger mechanism based on an ad counter minimum threshold / number.
The important thing is that the number in the notification message matches the ad counter number that the user sees in the Bubble UI, therefore, using filter hits is less desirable since there can be discrepancies between filter hits and ad counter
What to change
Create a new notification mechanism that will trigger a notification message when the ad counter number,
as displayed in the bubble UI, is at or between a specified range of numbers, for example...
between 10,000 and 49,999
between 50,000-99,999
more than 100,000
Attachments (1)
Change History (11)
comment:1 Changed on 02/05/2015 at 03:09:10 PM by annlee@adblockplus.org
- Description modified (diff)
comment:2 Changed on 02/05/2015 at 03:10:09 PM by annlee@adblockplus.org
- Description modified (diff)
comment:3 Changed on 03/30/2015 at 08:45:01 AM by annlee@adblockplus.org
- Verified working unset
Changed on 03/30/2015 at 08:50:00 AM by annlee@adblockplus.org
comment:4 Changed on 03/30/2015 at 08:58:12 AM by annlee@adblockplus.org
- Blocking 2162 added
- Description modified (diff)
comment:5 Changed on 04/04/2015 at 11:35:44 PM by fhd
- Blocking 2162 removed
comment:6 Changed on 06/26/2017 at 01:36:31 PM by jeen
- Cc sebastian@adblockplus.org added; annlee@… removed
- Tester set to Unknown
comment:7 Changed on 06/26/2017 at 01:43:18 PM by jeen
@sebastian I would like to resurrect this ticket as part of the cross-promotional initiative (https://intraforum.adblockplus.org/t/in-product-cross-promotion/1945). We are aiming for the messaging to be rolled out in September.
comment:8 Changed on 06/28/2017 at 01:56:51 PM by sebastian
- Cc sebastian wspee added; sebastian@adblockplus.org removed
As discussed in the meeting, our resources here are limited. So we won't be able to implement a bunch of changes to the notification system. But if it is established that this is the most useful thing we could do, we could potentially move forward with this single change. Though it might make sense to first finalize/update the spec, before moving forward with the implementation.
comment:9 Changed on 07/17/2017 at 03:17:21 PM by jeen
@sebastian to keep resources and effort minimal, we would only want to implement a trigger based on the ad count - the number of ads at which the notification is triggered should be adjustable. I don't personally see the spec as something that should block this from moving forward since this is a new trigger? But do correct me if I am wrong.
comment:10 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
.png.html){kind=link}
.png){kind=link}
Not really blocked by #2162 technically.