Opened on 02/17/2015 at 02:32:27 PM
Last modified on 04/25/2015 at 05:21:14 PM
#2006 new change
Remove ActionBarSherlock
| Reported by: | rjeschke | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
There hasn't been much movement in the ActionBarSherlock project during the last 1.5 years, and the author deprecated the project in Dec/2014 in favour of appcompat-v7 (https://developer.android.com/tools/support-library/features.html)'.
The sad thing is, that there is a bit of migration work to do, as we decided to not only use the ActionBar feature, but styles and helper classes. It's not as they are black magic and can be easily replaced by us, but it may take a few hours.
Still: as google officially provides a way to use the ActionBar on pre-API-11 devices, we should use it. Another benefit would be that we then have access to new features (like Inbox-Style notifications) which are currently unavailable to us because of conflicting libraries inside ABP and ActionBarSherlock.
Attachments (0)
Change History (2)
comment:1 Changed on 03/21/2015 at 04:03:13 PM by agnieszka.domanska
comment:2 Changed on 04/25/2015 at 05:21:14 PM by agnieszka.domanska
There is a problem with removing SherlockActionBar for Api < 11 as it requires PreferenceFragment usage that is not supported by appcompat library. I discussed it with Neet and wait for decision.
I'd like to work on this.