Opened on 02/17/2015 at 09:12:09 PM
Closed on 02/19/2015 at 02:08:03 PM
#2008 closed defect (fixed)
Texts are missing in the UI if language code doesn't have a region
| Reported by: | maf654321 | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, mapx | Blocked By: | |
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by mapx)
Environment
Mac OS X 10.10.2
Adblock Plus 1.8.10.1353
How to reproduce
Screenshot displaying the bug in effect is attached.
As I posted in adblockplus.org/forum/viewtopic.php?f=18&t=28206?
- Change primary language in Mac OS X to Gaelic, with English being the second language.
- Launch Safari and open the bubble UI by clicking the ABP icon
- Click Options
http://i.imgur.com/boZkUec.png
This group of settings consistently reproduces this bug for me, but I suspect other untranslated primary languages might also have a similar effect.
Observed behaviour
Both the dropdown, bubble UI and the options page are missing content. The dropdown is missing words, and the options page is almost blank, with only a few clickable boxes and a logo left. As well, if there is blocking lists already activated, the functionality is still somewhat broken, failing on Youtube.com at least.
http://i.imgur.com/EKXAlBu.png
http://i.imgur.com/cWvJErU.png
Expected behaviour
The Dropdown menu and Options page should be populated and usable.
Attachments (3)
Change History (8)
Changed on 02/17/2015 at 09:13:27 PM by maf654321
Changed on 02/17/2015 at 09:13:53 PM by maf654321
Options page
Changed on 02/17/2015 at 09:14:21 PM by maf654321
Dropdown Bubble UI
comment:1 Changed on 02/17/2015 at 09:31:38 PM by mapx
- Cc sebastian mapx added
- Component changed from Unknown to Platform
- Description modified (diff)
- Owner set to sebastian
comment:2 Changed on 02/17/2015 at 09:34:17 PM by mapx
(I didn't assign ... to sebastian ... how was this possible :O )
comment:3 Changed on 02/18/2015 at 08:53:23 AM by sebastian
- Priority changed from Unknown to P2
- Ready set
- Summary changed from Blank Toolbar Dropdown UI and Settings Page to Texts are missing in the UI if language code doesn't have a region
This regression were introduces by #1666. The change there assumes the region part of the language code to always be present, resulting in an error and breaking the UI if it isn't.
comment:4 Changed on 02/18/2015 at 08:55:40 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 02/19/2015 at 02:08:03 PM by sebastian
- Milestone set to Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from reviewing to closed
Language Settings