Opened on 02/18/2015 at 01:30:42 PM

Closed on 02/28/2015 at 12:45:51 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2010 closed change (fixed)

Replace "for each" loops with "for of" loops (Firefox)

Reported by: tschuster Assignee: tschuster
Priority: P4 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #312 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/6519778499887104/

Description (last modified by trev)

Background

Using for each is now deprecated and shows a warning in current Firefox nightlies. We are still using it in some UI code. Related: #2013.

What to change

Replace all usage of for each loops in the chrome/content/ui directory by for .. of loops.

Attachments (0)

Change History (9)

comment:1 Changed on 02/18/2015 at 05:48:55 PM by mapx

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Owner set to trev
  • Platform changed from Unknown to Firefox/Firefox Mobile

comment:2 Changed on 02/18/2015 at 06:10:08 PM by trev

  • Description modified (diff)
  • Keywords goodfirstbug added
  • Owner trev deleted
  • Priority changed from Unknown to P4
  • Ready set

Please never assign issues to people other than yourself.

comment:3 Changed on 02/18/2015 at 06:11:29 PM by trev

  • Summary changed from Remove some uses of "for each" with "for of" to Replace "for each" loops with "for of" loops (Firefox)

comment:4 Changed on 02/18/2015 at 06:12:25 PM by trev

  • Description modified (diff)

comment:5 Changed on 02/18/2015 at 06:14:20 PM by trev

  • Description modified (diff)

comment:6 Changed on 02/18/2015 at 07:53:14 PM by tschuster

  • Keywords goodfirstbug removed
  • Owner set to tschuster
  • Review URL(s) modified (diff)

comment:7 Changed on 02/18/2015 at 07:58:58 PM by tschuster

Oh sorry for not immediately assigning this properly. I also didn't update all for each uses chrome/content/ui so I am going to update my patch to do that.

comment:8 Changed on 02/28/2015 at 12:45:51 PM by tschuster

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/d9b4059a9f8f

comment:9 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tschuster.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.