Opened on 02/19/2015 at 08:30:53 PM

Closed on 02/27/2015 at 03:48:05 PM

#2020 closed defect (fixed)

build.py should be callable from any directory

Reported by:	fhd	Assignee:	trev
Priority:	P4	Milestone:
Module:	Automation	Keywords:	goodfirstbug
Cc:		Blocked By:
Blocking:		Platform:	Unknown
Ready:	yes	Confidential:	no
Tester:		Verified working:
Review URL(s):	http://codereview.adblockplus.org/5718624291520512/ http://codereview.adblockplus.org/5969528966086656/

Description (last modified by fhd)

Environment

adblockplus repository, revision ab709bdd81e1.

Pretty sure it affects most of our projects though.

How to reproduce

Change to any directory other than the adblockplus working directory.
Call build.py from there.

Observed behaviour

The build scripts are looking for various files in the current working directory, so this fails.

Expected behaviour

The current working directory shouldn't matter, the files should be expected next to build.py.

Change History (9)

comment:1 Changed on 02/19/2015 at 08:31:39 PM by fhd

Description modified (diff)

comment:2 Changed on 02/20/2015 at 09:29:47 AM by sebastian

Keywords goodfirstbug added
Priority changed from Unknown to P4
Ready set

comment:3 Changed on 02/25/2015 at 08:41:15 PM by trev

Owner set to trev

comment:4 Changed on 02/25/2015 at 08:41:27 PM by trev

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:5 Changed on 02/25/2015 at 09:00:00 PM by trev

Resolution set to fixed
Status changed from reviewing to closed

Fixed:

comment:6 Changed on 02/26/2015 at 11:18:02 PM by tschuster

I can't use build.py from the main directory anymore. Is that on purpose?

  File "/home/tom/projects/adblockplus/buildtools/packagerGecko.py", line 341, in createBuild
    files = Files(getPackageFiles(params), getIgnoredFiles(params),
  File "/home/tom/projects/adblockplus/buildtools/packagerGecko.py", line 58, in getPackageFiles
    for file in os.listdir(baseDir):
OSError: [Errno 2] No such file or directory: ''

comment:7 Changed on 02/27/2015 at 07:41:55 AM by trev

Resolution fixed deleted
Status changed from closed to reopened

Indeed - I always call the script as ./build.py. If you call it as build.py then BASE_DIR will be empty.

comment:8 Changed on 02/27/2015 at 07:43:46 AM by trev

Review URL(s) modified (diff)
Status changed from reopened to reviewing

comment:9 Changed on 02/27/2015 at 03:48:05 PM by trev

Resolution set to fixed
Status changed from reviewing to closed

Fixed again:

Context Navigation