Opened on 02/25/2015 at 04:29:58 PM
Closed on 02/27/2015 at 05:05:22 PM
Last modified on 05/20/2015 at 02:22:39 PM
#2041 closed defect (fixed)
Filter Preferences: Findbar not fully functional in Firefox 36
| Reported by: | mapx | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.6.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner, trev | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by trev)
Environment
FF 36 (Windows XP)
ABP 2.6.7.3897
How to reproduce
- Open Filter Preferences window.
- Press Ctrl+F to search for a filter, type "asdf123456789".
Expected result: the filter isn't found, so the input field should turn red and there should be a corresponding message.
Actual result: no visual feedback if filter isn't found. Also errors in Error Console:
NS_ERROR_FAILURE: Failure arg 0 [nsIEventListenerService.addSystemEventListener] findbar.xml:266:0
NS_ERROR_FAILURE: Failure arg 0 [nsIEventListenerService.removeSystemEventListener] findbar.xml:255:0
Background
The exception comes from the browser's findbar widget. It calls nsIEventListenerService.addSystemEventListener() with this._browser as first parameter. In our case its value isn't a DOM element however but a fake browser object, hence the exception. Originally it was calling this._browser.addEventListener() which we emulate. The only impact appears to be missing feedback if the search failed.
What to change
Instead of using a separate object, inject the properties of the fake browser into the filtersTree element. As this one is a real DOM element, nsIEventListenerService.addSystemEventListener() will work on it.
Attachments (0)
Change History (8)
comment:1 Changed on 02/25/2015 at 04:31:19 PM by mapx
- Cc greiner trev added
comment:2 Changed on 02/25/2015 at 04:50:45 PM by trev
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
comment:4 Changed on 02/25/2015 at 04:55:05 PM by trev
- Owner set to trev
comment:5 Changed on 02/25/2015 at 05:07:23 PM by trev
- Summary changed from FF 36, errors in console to Filter Preferences: Findbar not fully functional in Firefox 36
comment:6 Changed on 02/25/2015 at 05:10:03 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 02/27/2015 at 05:05:22 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Fixed: https://hg.adblockplus.org/adblockplus/rev/1adfc42ea8bb