Opened on 02/26/2015 at 12:36:25 PM
Closed on 11/10/2017 at 11:15:18 AM
#2048 closed change (rejected)
Make tests use async() instead of deprecated asyncTest() and start() functions
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | goodfirstbug |
| Cc: | trev | Blocked By: | #2047 |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by trev)
Background
QUnit's asyncTest() and start() functions have been deprecated (the former still being fine in setup and teardown). So once we updated to QUnit 1.17.1 (#2047), we should adapt asynchronous tests to use the new API instead.
What to change
Replace asyncTest() and start() with done = assert.async() and done() in all tests in the adblockplustests repository.
Hints for testers
The test suite isn't part of the build. So there is nothing to test here.
Attachments (0)
Change History (5)
comment:1 Changed on 02/26/2015 at 02:17:35 PM by sebastian
- Description modified (diff)
- Summary changed from Make tests uses async() instead deprecated start()/stop() to Make tests uses async() instead asyncTest(), start() and stop()
comment:2 Changed on 02/26/2015 at 02:19:43 PM by trev
- Component changed from Core to Adblock-Plus-for-Firefox
- Description modified (diff)
- Platform changed from Unknown to Firefox/Firefox Mobile
- Priority changed from Unknown to P4
- Ready set
- Summary changed from Make tests uses async() instead asyncTest(), start() and stop() to Make tests use async() instead of deprecated asyncTest() and start() functions
comment:3 Changed on 02/26/2015 at 02:37:01 PM by trev
- Keywords goodfirstbug added
comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
comment:5 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Note: See
TracTickets for help on using
tickets.
Made Firefox and Firefox mobile available as seperate platforms.