Opened on 02/26/2015 at 03:18:47 PM
Closed on 02/26/2015 at 07:11:36 PM
Last modified on 02/26/2015 at 07:20:15 PM
#2050 closed change (fixed)
Bubble popup shouldn't be reusing the logo from the first-run page
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | User-Interface | Keywords: | |
| Cc: | sven, sebastian, greiner | Blocked By: | |
| Blocking: | #1533 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by greiner)
Background
The bubble popup is currently scaling down the logo we use on the first-run page (99x100 to 55x55). We should really be using a logo with the right size here.
What to change
Use the existing 64x64 icon64.png image as its size most closely matches the one used right now.
Attachments (2)
Change History (13)
comment:1 Changed on 02/26/2015 at 03:21:32 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/26/2015 at 03:22:36 PM by trev
- Cc greiner added
- Component changed from Platform to User-Interface
Changed on 02/26/2015 at 03:31:57 PM by trev
Changed on 02/26/2015 at 03:32:04 PM by trev
comment:3 Changed on 02/26/2015 at 03:34:47 PM by trev
comment:4 follow-up: ↓ 5 Changed on 02/26/2015 at 03:52:03 PM by sebastian
How about <img src="abp-64.png" srcset="abp-128.png 2x"> for full DPI? ;)
comment:5 in reply to: ↑ 4 Changed on 02/26/2015 at 04:06:49 PM by greiner
- Description modified (diff)
- Ready set
Replying to sebastian:
How about <img src="abp-64.png" srcset="abp-128.png 2x"> for full DPI? ;)
It might make more sense to do that in a separate issue since none of the other images in the popup are optimized for high-DPI screens at this point so they'd need to be changed as well. Also note that abp-64.png is called icon64.png and that there is no abp-128.png in the "adblockplus" repository so that would need to be added first.
comment:6 Changed on 02/26/2015 at 04:09:18 PM by sebastian
Well, this change is still in the adblockpluschrome repo. But yeah, I'm fine with introducing srcset with a separate issue. It just came to my mind when I read "Retina". ;)
comment:7 Changed on 02/26/2015 at 04:19:36 PM by trev
Actually, that's the one image in the popup where using a high-resolution image makes a huge difference - and it's absolutely trivial. So I implemented it.
comment:8 Changed on 02/26/2015 at 07:00:37 PM by greiner
- Priority changed from Unknown to P1
comment:9 Changed on 02/26/2015 at 07:11:36 PM by trev
- Priority changed from P1 to Unknown
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 02/26/2015 at 07:12:01 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Priority changed from Unknown to P1
comment:11 Changed on 02/26/2015 at 07:20:15 PM by trev
- Blocking 1533 added
What this currently looks like (scaled down by factor 2 because this is a Retina Mac):