Opened on 03/01/2015 at 12:54:32 PM
Closed on 03/03/2015 at 08:32:09 AM
#2067 closed change (fixed)
Unify logic retrieving the UI locale
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | #2071 | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
Currently in i18n.js, the UI locale is retrieved for Chrome and Safari by duplicating the logic from Utils.appLocale in order to not message the background page. However, on Firefox we need to message the background page anyway. So this logic could be simplified and unified by always messaging the background page, relying on Utils.appLocale for all platforms.
What to change
Unify the logic by messaging the background page and relying on Utils.appLocale for all platforms.
Hints for testers
Make sure that the lang and dir attributes are correctly set for document element on the first run page (on Firefox, Chrome and Safari), the options page (on Chrome and Safari), icon popup (on Chrome and Safari) and the "Block element" dialog (on Chrome and Safari).
Attachments (0)
Change History (3)
comment:1 Changed on 03/01/2015 at 12:55:32 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/02/2015 at 11:52:23 AM by sebastian
- Blocked By 2071 added
comment:3 Changed on 03/03/2015 at 08:32:09 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/adblockplusui/rev/9dca4a5f440c