Opened on 03/02/2015 at 01:00:23 PM

Closed on 03/04/2015 at 07:46:11 PM

#2072 closed change (fixed)

Don't duplicate 128x128 icon in Chrome builds (adblockplusui)

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5244235691327488/

Description

Background

Currently, the 128x128 icon exists twice in Chrome builds: once as abp-icon-big.png as used by the first-run page (adblockplusui repository) and another time as abp-128.png as used by the Chrome extension itself (adblockpluschrome repository).

What to change

Rename abp-icon-big.png into abp-128.png for consistency. Try to load icons/detailed/abp-128.png first (the path it will be available under in the adblockpluschrome repository) and only fall back to skin/abp-128.png if it doesn't work.

Attachments (0)

Change History (3)

comment:1 Changed on 03/02/2015 at 01:53:00 PM by sebastian

  • Cc sebastian added

comment:2 Changed on 03/02/2015 at 02:13:43 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/04/2015 at 07:46:11 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplusui/rev/457cd7815a8a

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.