Opened on 03/02/2015 at 04:34:10 PM
Closed on 04/08/2015 at 02:54:04 PM
#2077 closed defect (fixed)
Overlay highlighting selected element is covered by descendant with higher z-index
| Reported by: | passbrains | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-141
Environment
Windows + Vista 64bit + Chrome + English
ABP version Version: 1.8.11.1363
How to reproduce
- Install latest ABP extension on chrome.
- Block the wrapper by ABP option block element. see screenshot1
- Add the filter.
- Refresh the page and observe.
Verfied on 2 builds
Version: 1.8.11.1361
Version: 1.8.11.1363
Observed behaviour
Only the areas on the left and right are highlighted. However, the whole page's content is blocked. This is because there is an descendant with a higher z-index than the ancestor the overlay is created for.
Expected behaviour
The whole area of the element that is going to be blocked should be highlighted.
Attachments (2)
Change History (7)
Changed on 03/02/2015 at 04:34:14 PM by passbrains
Changed on 03/02/2015 at 04:34:15 PM by passbrains
comment:1 Changed on 03/02/2015 at 06:00:47 PM by mapx
- Component changed from Unknown to Platform
- Description modified (diff)
- Owner set to sebastian
comment:2 Changed on 04/05/2015 at 06:18:42 PM by sebastian
- Cc sebastian added
- Owner sebastian deleted
- Priority changed from Unknown to P3
- Verified working unset
comment:3 Changed on 04/08/2015 at 01:27:03 PM by sebastian
- Description modified (diff)
- Owner set to sebastian
- Ready set
- Summary changed from Wrapper element is not blocked to Overlay highlighting selected element is covered by descendant with higher z-index
The z-index calculation doesn't consider descendants but only the selected element and its ancestors. Eventually, it's not possible to always inject the overlay in a way that it only covers the selected element's content. So we probably should just inject it with the highest possible z-index, potentially covering a little too much. This will simplify the logic and is consistent with the behavior of the inspector.
comment:4 Changed on 04/08/2015 at 01:28:36 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 04/08/2015 at 02:54:04 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Yeah, z-index calculation strikes again, apparently not a trivial task.