Opened on 03/10/2015 at 04:19:58 PM
Closed on 04/15/2015 at 09:17:20 AM
Last modified on 05/14/2015 at 02:11:30 PM
#2118 closed change (fixed)
[adblockplus.org Anwiki to CMS migration] Generate TOC
| Reported by: | saroyanm | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | Blocked By: | #2119, #2306 | |
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
We are using "anwtoc" tag to generate table of content list that uses content of the page of it's "page" attribute to generate list of subcontent in the referenced page. Currently it's just getting the id of heading elements in the page and generates list.
You can see the current implementation in abp_output plugin in Anwiki.
Here are the pages that are affected by that:
- en/android-about
- en/android-config
- en/faq
What to change
Update migration script to generate Table of Content according to "anwtoc" tag in anwiki.
Attachments (0)
Change History (11)
comment:1 Changed on 03/10/2015 at 04:35:31 PM by saroyanm
- Ready set
comment:2 Changed on 03/10/2015 at 05:05:42 PM by saroyanm
- Blocked By 2119 added
comment:3 Changed on 03/10/2015 at 05:08:03 PM by saroyanm
Replying to saroyanm:
So I guess we can hardcode "linked TOC" for now.
While we will need that solution anyway before large scale update.
I've created "Blocked By" ticket accordingly.
comment:4 Changed on 04/07/2015 at 02:52:28 PM by kzar
- Owner set to kzar
- Verified working unset
comment:5 Changed on 04/07/2015 at 09:06:30 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 04/13/2015 at 11:10:11 AM by kzar
- Blocked By 2306 added
comment:9 Changed on 04/15/2015 at 09:17:20 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 05/07/2015 at 11:48:55 AM by kzar
comment:11 Changed on 05/14/2015 at 02:11:30 PM by Ross
- Verified working set
Implemented and working.
Tested by:
Running the website converter script as per the read me and checking the TOC output for the mentioned pages.
Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387
Currently toclist method in our "CMS" uses HTML as it's attribute, but not path to content.
So I guess we can hardcode "linked TOC" for now, but I think we will need solution for future, so the toclist could also accept path to file, not sure whether it would be easy to achiev within our CMS.