Opened on 03/11/2015 at 08:46:10 PM
Closed on 03/11/2015 at 10:48:10 PM
Last modified on 05/14/2015 at 03:05:07 PM
#2130 closed change (fixed)
[adblockplus.org Anwiki to CMS migration] Get rid of unconditional sitescripts dependency
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
Once #2126 is fixed it can no longer be assumed that sitescripts are present if our CMS is running. This is an assumption made by the get_subscriptions filter in the web.adblockplus.org repository however. It currently makes the test server error out for any page, not just the subscription page.
What to change
Import sitescripts.subscriptions.subscriptionParser only when the filter is used, not immediately. This way if sitescripts aren't there only the subscriptions page will error out.
Attachments (0)
Change History (3)
comment:1 Changed on 03/11/2015 at 08:48:58 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/11/2015 at 10:48:10 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 05/14/2015 at 03:05:07 PM by Ross
- Verified working set
This has been done. Only the subscriptions page will error if sitescripts is missing.
web.adblockplus.org / r68
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/web.adblockplus.org/rev/933c95516028