Opened on 03/13/2015 at 02:16:06 PM
Closed on 04/25/2015 at 03:05:21 PM
Last modified on 05/13/2015 at 03:32:34 PM
#2140 closed change (fixed)
[adblockplus.org Anwiki to CMS migration] Make sure translatable links don't break up strings
| Reported by: | trev | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | 2015q2 |
| Cc: | Blocked By: | #2139 | |
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
Currently, a translatable link in the middle of a sentence will break up the sentence into three separate strings. This is very suboptimal.
What to change
Once #2139 is fixed, generate markup like {{str There is more <a href="{{link http://example.com/}}">information</a> available on this.}} for translatable strings.
Attachments (0)
Change History (5)
comment:1 Changed on 04/21/2015 at 09:12:29 AM by fhd
- Keywords 2015q2 added
- Verified working unset
comment:2 Changed on 04/22/2015 at 10:29:22 AM by kzar
- Owner set to kzar
comment:3 Changed on 04/25/2015 at 03:05:21 PM by kzar
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from new to closed
comment:4 Changed on 04/28/2015 at 06:07:46 PM by trev
comment:5 Changed on 05/13/2015 at 03:32:34 PM by Ross
- Verified working set
Working.
Tested by:
Running the website converter script as per the read me and checking the output for translatable links.
Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387
Note: See
TracTickets for help on using
tickets.
This was pushed as part of https://hg.adblockplus.org/web.adblockplus.org/rev/73e955ef03d6.