Opened on 03/13/2015 at 05:35:00 PM

Closed on 03/23/2015 at 08:58:06 PM

Last modified on 05/14/2015 at 03:53:10 PM

#2143 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] urlencode filter shouldn't be expected to be present

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5111778631483392/

Description

Background

Jinja2 added support for the urlencode filter with version 2.7. However, the version available for Ubuntu 12.04 is older meaning that subscriptionList.tmpl currently errors out.

What to change

Implement our own version of that filter, so we don't need to rely on the built-in filter.

Attachments (0)

Change History (4)

comment:1 Changed on 03/13/2015 at 05:35:09 PM by trev

  • Blocking 2035 added

comment:2 Changed on 03/13/2015 at 05:37:14 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/23/2015 at 08:58:06 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 05/14/2015 at 03:53:10 PM by Ross

  • Verified working set

Done. Subscriptions page doesn't error out.

Tested on:
http://beta.adblockplus.org/en/subscriptions

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.