Opened on 03/13/2015 at 08:55:22 PM

Closed on 03/13/2015 at 09:18:12 PM

#2145 closed defect (fixed)

[cms] Strings from random locales show up on "English" pages

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5361415552499712/

Description

How to reproduce

  1. Run python -m cms.bin.generate_static_pages on the web.adblockplus.org repository.
  2. Inspect the results, e.g. the en/about file.

Observed behaviour

Menu contains strings from random languages.

Expected behaviour

Menu language should be English only.

Background

The problem is due to the dictionary returned by source.read_locale() being modified. python -m cms.bin.generate_static_pages memoizes the result of this call, so on subsequent calls the same modified dictionary will be returned.

Attachments (0)

Change History (2)

comment:1 Changed on 03/13/2015 at 08:56:43 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/13/2015 at 09:18:12 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/cms/rev/bcc7a00aa7be

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.