Opened on 03/25/2015 at 12:35:25 PM
Closed on 05/20/2015 at 09:31:28 AM
Last modified on 05/21/2015 at 09:26:55 PM
#2214 closed change (fixed)
Add message to Adblock Plus home page about mobile beta launch
| Reported by: | annlee@adblockplus.org | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | Blocked By: | #2213 | |
| Blocking: | #2436 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): |
http://codereview.adblockplus.org/4726834268733440/ |
||
Description (last modified by annlee@adblockplus.org)
Background
The message tells people about the mobile browser beta launch.
What to change
The following change may not go live until PR announces the beta / press release. This issue will be updated accordingly.
At http://adblockplus.org, add a text message as shown in the attached layout and style guide to be displayed to users in all languages.
The text of the message shall be: Be the first to experience the new Adblock Browser for smartphones and tablets. Get it here.
The 'Get it here' shall be a hyperlink, and link to the landing page being created by #2213
Additional Notes
The message should not go live until PR announces the beta / press release. Tentatively, this is around May 19 (a Tuesday). Code freeze is May 6. I will update the ticket as soon as these dates are finalized.
Attachments (2)
Change History (27)
Changed on 03/25/2015 at 12:35:54 PM by annlee@adblockplus.org
comment:1 Changed on 03/25/2015 at 12:39:24 PM by annlee@adblockplus.org
- Description modified (diff)
comment:3 Changed on 03/25/2015 at 04:22:41 PM by annlee@adblockplus.org
- Description modified (diff)
comment:4 follow-up: ↓ 6 Changed on 03/25/2015 at 04:54:21 PM by philll
@Ann-lee: When writing issues, please always imagine, you are telling the next random person passing by the street what's written in the "what to change" section. If that random person perfectly withtout any sort of question understood what you wanted, the description is fine.
I really put on question, whether this works with the current what to change section.
Also, please attach ALL files neccessary to fix an issue directly in the issue AND link them in your description. Texts should be directly within the description itself, as that has a version history.
comment:5 in reply to: ↑ 2 Changed on 03/25/2015 at 05:39:28 PM by annlee@adblockplus.org
Replying to saroyanm:
add this message
I would really like to have the message in the ticket, because it's not selectable in the image, it will reduce the chance to misspell it.
text added to ticket
should appear just above the fold
What do you mean by fold ?
never mind, sorry for confusion, deleted this part
Changed on 03/25/2015 at 05:42:19 PM by annlee@adblockplus.org
comment:6 in reply to: ↑ 4 Changed on 03/25/2015 at 05:47:04 PM by annlee@adblockplus.org
Replying to philll:
@Ann-lee: When writing issues, please always imagine, you are telling the next random person passing by the street what's written in the "what to change" section. If that random person perfectly withtout any sort of question understood what you wanted, the description is fine. I really put on question, whether this works with the current what to change section.
I'm new to this, and have not opened many tickets yet, so obviously there will be problems. What would help me are specific corrections, as @saroyanm has already done.
A general 'lecture' such as this will not help the situation nor help me improve my tickets. Is there something else that's lacking beyond what @saroyanm has already commented on?
Also, please attach ALL files neccessary to fix an issue directly in the issue AND link them in your description. Texts should be directly within the description itself, as that has a version history.
done
comment:7 Changed on 03/26/2015 at 10:39:04 AM by annlee@adblockplus.org
- Description modified (diff)
- Summary changed from Message on ABP.org home page about mobile beta launch to Add message to Adblock Plus home page about mobile beta launch
comment:8 Changed on 03/26/2015 at 10:41:43 AM by annlee@adblockplus.org
- Description modified (diff)
comment:9 follow-up: ↓ 11 Changed on 03/31/2015 at 03:04:40 PM by philll
- Description modified (diff)
I cleaned up your description a bit. Please check whether everything is still correct.
comment:10 Changed on 03/31/2015 at 07:07:36 PM by annlee@adblockplus.org
- Description modified (diff)
comment:11 in reply to: ↑ 9 Changed on 03/31/2015 at 07:13:32 PM by annlee@adblockplus.org
Replying to philll:
I cleaned up your description a bit. Please check whether everything is still correct.
Thanks @philll, looks good.
Had to sort out some issues with PR & legal today, which affected this ticket, hence my delay in updating.
The change (which is already reflected in the Background and What to change), is that we no longer need to limit the message to english-speaking users, as explained in discourse
comment:12 Changed on 04/01/2015 at 09:16:12 AM by philll
- Description modified (diff)
Fixed the attachment links that contain way too many whitepsaces.
comment:13 Changed on 04/01/2015 at 02:00:58 PM by saroyanm
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:14 Changed on 04/21/2015 at 12:12:02 PM by saroyanm
- Description modified (diff)
comment:15 Changed on 04/21/2015 at 12:19:14 PM by saroyanm
- Owner set to saroyanm
comment:16 Changed on 04/21/2015 at 01:32:16 PM by annlee@adblockplus.org
- Description modified (diff)
comment:18 Changed on 04/28/2015 at 05:11:00 PM by saroyanm
- Review URL(s) modified (diff)
comment:19 Changed on 04/28/2015 at 05:11:14 PM by saroyanm
- Status changed from new to reviewing
comment:20 Changed on 04/29/2015 at 01:55:07 PM by saroyanm
- Blocking 2436 added
comment:24 Changed on 05/11/2015 at 04:00:26 PM by Ross
The message has been added to the home page and looks the same across browsers. After applying the style diff's correctly it looks fine.
Tested with:
| IE | 8.0.6001 | Windows XP |
| IE | 9.0.8112 | Windows 7 |
| IE | 10.0.9200 | Windows 7 |
| IE | 11.0.9600 | Windows 8.1 |
| Chrome | 42.0.2311.135 | Windows 8.1 |
| Opera | 29.0.1795.47 | Windows 8.1 |
| Firefox | 37.0.2 | Windows 8.1 |
| Chrome | 42.0.3211.111 | Android 4.2.2 |
comment:25 Changed on 05/13/2015 at 12:12:37 PM by Ross
Re-tested Adblock Browser pages as part of the CMS (instead of Anwiki). Message is displayed correctly as expected.
A related bug affects these specific pages in IE8: #2515
Tested with:
cms / r42
web.adblockplus.org / r86 (with patches)
Tested on:
| IE | 8.0.6001 | Windows XP |
| IE | 9.0.8112 | Windows 7 |
| IE | 10.0.9200 | Windows 7 |
| IE | 11.0.9600 | Windows 8.1 |
| Chrome | 42.0.2311.135 | Windows 8.1 |
| Opera | 29.0.1795.47 | Windows 8.1 |
| Firefox | 37.0.2 | Windows 8.1 |
| Chrome | 42.0.3211.111 | Android 4.2.2 |
comment:26 Changed on 05/13/2015 at 12:12:48 PM by Ross
- Verified working set
comment:27 Changed on 05/18/2015 at 06:29:42 PM by saroyanm
- Review URL(s) modified (diff)
comment:28 Changed on 05/20/2015 at 09:31:28 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:29 Changed on 05/21/2015 at 09:26:55 PM by fhd
- Sensitive unset
I would really like to have the message in the ticket, because it's not selectable in the image, it will reduce the chance to misspell it.
What do you mean by fold ?