Opened on 03/30/2015 at 01:56:46 PM
Closed on 04/01/2015 at 08:39:55 AM
Last modified on 07/09/2019 at 12:00:05 PM
#2235 closed change (fixed)
[JSHydra] Update jsshell to ESR31 to support new generator syntax
Reported by: | trev | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #1602 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sebastian)
Background
Currently, JSHydra will convert Mozilla-specific generators into functions returning arrays. E.g. original function is:
function foo() { yield "bar"; }
This becomes:
function foo() { var result = []; result.push("bar"); return result; }
However, the standard-compliant syntax for generator functions looks like:
function foo*() { yield "bar"; }
So we have to update Mozilla's jsshell used by jshydra to parse the
What to change
Update Mozilla's jsshell, downloaded on-the-fly when using jshydra, to support the new generator syntax.
Attachments (0)
Change History (7)
comment:1 Changed on 03/30/2015 at 01:58:05 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 03/31/2015 at 01:51:31 PM by sebastian
- Description modified (diff)
- Owner set to sebastian
comment:3 Changed on 03/31/2015 at 01:52:12 PM by sebastian
- Summary changed from [JSHydra] Convert ES6 generators to regular functions to [JSHydra] Update jsshell to ESR31 to support new generator syntax
comment:4 Changed on 03/31/2015 at 01:54:57 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 04/01/2015 at 08:39:55 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/27/2015 at 11:31:26 AM by sebastian
- Blocking 2425 added
comment:7 Changed on 04/27/2015 at 11:40:57 AM by sebastian
- Blocking 2425 removed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/jshydra/rev/8c4ee25543eb