Opened on 03/30/2015 at 04:42:22 PM

Closed on 05/28/2015 at 02:59:00 PM

Last modified on 07/22/2015 at 10:27:20 AM

#2237 closed change (fixed)

Add unit tests for notification opt-out

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By: #2192
Blocking: #2191 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5654617534758912/

Description (last modified by trev)

Background

In #2191 we added opt-out capabilities for notifications which should be tested to make sure they don't interfere with the existing handling of notifications.

What to change

The following new scenarios should be tested:

  • Calling Notification.getNextToShow() should return critical notifications after the "*" category was put into list of ignored categories using the method provided in #2192
  • Calling Notification.getNextToShow() should ignore information notifications after the "*" category was put into list of ignored categories using the method provided in #2192
  • extensions.adblockplus.notifications_showui should be set to true after calling the method provided in #2192 for toggling category visibility

Attachments (0)

Change History (4)

comment:1 Changed on 04/10/2015 at 09:58:30 PM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 04/13/2015 at 04:12:39 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 05/28/2015 at 02:59:00 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 07/22/2015 at 10:27:20 AM by trev

  • Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus
  • Tester set to Unknown

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
 
Note: See TracTickets for help on using tickets.