Opened on 04/02/2015 at 10:24:47 AM
Closed on 04/20/2015 at 04:24:47 PM
#2265 closed change (fixed)
Remove deprecated logic from Utils.runAsync() on Chrome/Opera/Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #2264 | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Utils.runAsync() is used to run a callback asynchronously. When that function was introduced in Adblock Plus for Firefox, there was no Function.bind(). So Utils.runAsync() optionally takes the context and arguments the callback is called with. However, this isn't necessary anymore, and with #2264 the core code will bind the callback before passing it as single argument to Utils.runAsync(). So we can simplify the implementation here as well.
What to change
Simplify the implementation of Utils.runAsync(), dropping support for specifying this and arguments passed to the callback. And adapt code using Uitls.runAsync() binding the callback there.
Attachments (0)
Change History (2)
comment:1 Changed on 04/02/2015 at 10:26:24 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/20/2015 at 04:24:47 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/3f260a12dd39