Opened on 04/04/2015 at 11:51:15 PM

Closed on 08/06/2015 at 06:32:28 PM

Last modified on 08/10/2015 at 03:15:10 PM

#2277 closed change (fixed)

[Send notifications to a subset of the user base] Use the new notification.json handler

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Kirill Blocked By: #2276, #2880
Blocking: #2162, #2313, #2314, #2365 Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/6380170118168576/

Description

Background

See #2162.

What to change

#2276 provides a new handler for notification.json requests that can handle groups. We need to use that one on the notification servers (should be rolled out gradually and tested carefully). We most definitely need to cache the response as discussed in #2162.

Attachments (0)

Change History (10)

comment:1 Changed on 04/04/2015 at 11:51:48 PM by fhd

  • Blocked By 2276 added
  • Blocking 2162 added

comment:2 Changed on 04/12/2015 at 03:24:51 PM by fhd

  • Owner set to fhd

comment:3 Changed on 04/12/2015 at 11:05:41 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/14/2015 at 05:34:07 AM by matze

  • Blocking 2313 added

comment:5 Changed on 04/14/2015 at 06:04:23 AM by matze

  • Blocking 2314 added

comment:6 Changed on 04/21/2015 at 08:53:56 AM by fhd

  • Blocking 2365 added

comment:7 Changed on 05/19/2015 at 08:59:44 AM by Kirill

  • Cc Kirill added

comment:8 Changed on 06/30/2015 at 01:15:42 PM by Ross

  • Tester set to Ross
  • Verified working set

This was implemented/done. The new handler appears to be working as expected however is was tested without caching for now. I've created to test with caching enabled (#2739).

comment:9 Changed on 08/06/2015 at 06:32:28 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 08/10/2015 at 03:15:10 PM by matze

  • Blocked By 2880 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
 
Note: See TracTickets for help on using tickets.