Opened on 03/28/2014 at 04:13:27 PM

Closed on 04/11/2014 at 09:00:56 AM

Last modified on 04/13/2014 at 06:31:58 PM

#229 closed defect (fixed)

[Australis] "Select element to hide" not visible when icon is placed in the menu

Reported by: arthur Assignee: saroyanm
Priority: P2 Milestone: Element-Hiding-Helper-1.3
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/4734919200735232/

Description (last modified by arthur)

Environment

  • Latest Nightly
  • Windows 8.1 Pro x64
  • Adblock Plus 2.5.1.3788
  • Element Hiding Helper 1.2.4a.453

How to reproduce

  1. Customize the appearance of Firefox via right-clicking on the tab bar
  2. Drag the ABP icon to the menu like shown in the screenshot

Observed behaviour

When you click the icon, "Select element to hide" is missing in the context menu.

Expected behaviour

It should be visible.

Forum topic

https://adblockplus.org/forum/viewtopic.php?f=11&t=21466

Attachments (1)

ehh.png (101.2 KB) - added by arthur on 03/28/2014 at 04:13:36 PM.

Download all attachments as: .zip

Change History (10)

Changed on 03/28/2014 at 04:13:36 PM by arthur

comment:1 Changed on 03/28/2014 at 04:14:22 PM by arthur

  • Description modified (diff)

comment:2 Changed on 04/02/2014 at 01:43:00 PM by arthur

  • Ready set

comment:3 Changed on 04/10/2014 at 01:37:27 PM by saroyanm

  • Owner set to saroyanm
  • Status changed from new to assigned

comment:4 Changed on 04/10/2014 at 06:56:56 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:5 Changed on 04/11/2014 at 05:38:17 AM by trev

  • Cc trev added

As noted in the review, the same issue affects Diagnostics and Crawler extensions as well.

comment:6 Changed on 04/11/2014 at 09:00:56 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed for Diagnostics and Crawler as well.

comment:7 Changed on 04/11/2014 at 09:08:53 AM by arthur

  • Verified working set

comment:9 Changed on 04/13/2014 at 06:31:58 PM by trev

  • Milestone set to Element-Hiding-Helper-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.