Opened on 04/10/2015 at 11:07:02 AM

Closed on 04/13/2015 at 12:40:18 PM

#2298 closed defect (fixed)

"Block element" from context menu doesn't reset previous state

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6194342989398016

Description

How to reproduce

  1. Go to ​https://google.com
  2. Click the ABP icon
  3. Click "Block element"
  4. Select the search field
  5. Right-click the Google logo
  6. Select "Block element" from the context menu

Observed behaviour

Both the search field and the logo are highlighted, and two dialogs are shown (covered by each other).

Expected behaviour

The previously selected element should no longer be highlighted and respective dialog should be closed when selecting another element (from the context menu).

Attachments (0)

Change History (2)

comment:1 Changed on 04/10/2015 at 11:07:52 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/13/2015 at 12:40:18 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/90e4c78c0490

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.