Opened on 04/11/2015 at 08:03:11 AM
Closed on 04/16/2015 at 06:44:13 PM
#2301 closed change (fixed)
Improve beta.adblockplus.org configuration
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | matze | Blocked By: | |
Blocking: | #2035 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
http://codereview.adblockplus.org/4808447505727488/ |
Description
Background
beta.adblockplus.org has been set up as a minimal web server right now. However, our current website has lots of additional functionality.
What to change
Add custom nginx configuration for UA detection, CSP headers, devbuilds redirects etc. Set up multiplexer locations currently available via adblockplus.org. Proxy access to URLs like /blog or /forum.
Attachments (0)
Change History (7)
comment:1 Changed on 04/14/2015 at 09:29:48 PM by trev
comment:2 Changed on 04/15/2015 at 11:19:34 AM by trev
There were also some redirector entries referring to pages that have been removed:
if ($arg_link ~ "^knownIssues_(\w+)") { set $link "known-issues"; set $anchor "#$1"; } if ($arg_link ~ "^knownIssuesChrome_(\w+)") { set $link "known-issues-chrome"; set $anchor "#$1"; }
These are not part of the new config either.
comment:3 Changed on 04/15/2015 at 12:23:58 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/15/2015 at 03:03:11 PM by trev
- Owner set to trev
comment:5 Changed on 04/16/2015 at 12:21:05 PM by trev
- Review URL(s) modified (diff)
Pushed https://hg.adblockplus.org/infrastructure/rev/49377f583088 but realized that this commit had issues. Follow-up patch under review, the changes have already been deployed to the server.
comment:6 Changed on 04/16/2015 at 12:40:31 PM by trev
- Review URL(s) modified (diff)
Pushed https://hg.adblockplus.org/infrastructure/rev/fad1f8ee61fa, one more change under review.
comment:7 Changed on 04/16/2015 at 06:44:13 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed links in forum and blog as well: https://hg.adblockplus.org/infrastructure/rev/cee777eae620
The new configuration is significantly different from the old one, that's unavoidable given the completely different setups. So I decided to remove a bunch of ancient redirects:
These refer to URLs that existed at least three years ago.