Opened on 04/15/2015 at 03:44:43 PM
Closed on 04/20/2015 at 11:53:47 AM
Last modified on 05/14/2015 at 08:58:36 PM
#2323 closed defect (fixed)
Links aren't being processed properly on the home page
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): |
http://codereview.adblockplus.org/4802066526502912/ |
||
Description
How to reproduce
- Go to https://beta.adblockplus.org/
- Check the source code
Observed behaviour
Page links haven't been resolved, e.g. <a href="android"> stayed there as a relative link.
Expected behaviour
The links should have been resolved, e.g. <a href="/en/android">. This behavior is implicit for raw HTML files but has to be requested explicitly in templates like the home page.
Attachments (0)
Change History (9)
comment:1 Changed on 04/15/2015 at 06:56:59 PM by trev
- Owner set to trev
comment:2 Changed on 04/15/2015 at 06:59:07 PM by trev
- Component changed from Unknown to Sitescripts
comment:3 Changed on 04/15/2015 at 07:14:49 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/16/2015 at 07:59:38 AM by trev
- Status changed from reviewing to reopened
Fixed the CMS part: https://hg.adblockplus.org/cms/rev/4db7e0c3d360
Rest of it should be resolved in the conversion script.
comment:5 Changed on 04/16/2015 at 08:26:30 PM by trev
- Resolution set to fixed
- Status changed from reopened to closed
Fixed the remaining part: https://hg.adblockplus.org/web.adblockplus.org/rev/56f0828c8d64
comment:6 Changed on 04/20/2015 at 11:37:06 AM by trev
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening - the solution implemented here is incomplete, we have a problem with images as well.
comment:7 Changed on 04/20/2015 at 11:42:05 AM by trev
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
Opted for automatic link resolution for templates, same as for other formats.
comment:8 Changed on 04/20/2015 at 11:53:47 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 05/14/2015 at 08:58:36 PM by Ross
- Verified working set
Fixed.
Tested by:
Checking links/images on beta.adblockplus.org and checking home page links after running conversation script.
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387
CMS change to make sure that links in translatable strings are always resolved is under review. What's left is links outside translatable strings - the conversion script needs to turn them calls of the linkify filter.