Opened on 04/18/2015 at 07:08:07 AM

Closed on 04/18/2015 at 06:57:05 PM

Last modified on 05/14/2015 at 08:59:05 PM

#2344 closed defect (fixed)

[cms] <em> in translatable strings is being turned into <em >

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/6556935134380032/

Description

How to reproduce

  1. View the source of ​https://beta.adblockplus.org/en/android-install

Observed behaviour

The source adds en extra whitespace to <em> tags: from <em >unknown sources</em> is

Expected behaviour

No extra whitespace: from <em>unknown sources</em> is

Attachments (0)

Change History (3)

comment:1 Changed on 04/18/2015 at 07:11:34 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/18/2015 at 06:57:05 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/cms/rev/2f7c16917212

comment:3 Changed on 05/14/2015 at 08:59:05 PM by Ross

  • Verified working set

Fixed.

Tested by:
Checking for <em > in source of beta.adblockplus.org and when running a local copy of the CMS.

cms / r42
web.adblockplus.org / r68

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.