Opened on 04/20/2015 at 09:42:47 AM

Closed on 05/06/2015 at 05:00:50 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2351 closed change (fixed)

Improve menu item for whitelisting the current site

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords: 2015q2
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5365916275572736

Description (last modified by fhd)

Background

The menu item for whitelisting the current site that's added by ABP has two issues:

  1. It shows up at the bottom of the list - on a typical smartphone screen that means the user has to scroll to see it. It is in fact so hard to notice that I was pretty sure it wasn't working...
  1. It says: "ABP: Disable on [domain]". We've never talking about Adblock Plus (let alone its abbreviation) in Adblock Browser.

What to change

The menu item should:

  1. Be a checkbox item, just like "Request Desktop Site".
  2. Have the label "Block Ads on this Site".
  3. Show up right before "Request Desktop Site".
  4. Never disappear, but get disabled and unchecked on local sites instead.

Attachments (0)

Change History (13)

comment:1 Changed on 04/21/2015 at 09:10:58 AM by fhd

  • Keywords 2015q2 added

comment:2 Changed on 04/21/2015 at 11:20:34 AM by rjeschke

Works for me, are you sure we need to fix something here? (Well, maybe it's in the wrong menu?)

https://www.dropbox.com/s/jzfcqvhxql1ficy/disable_on_heise.png

Last edited on 04/21/2015 at 11:21:25 AM by rjeschke

comment:3 Changed on 04/24/2015 at 01:28:02 PM by fhd

Yes, it actually does work. However I see two problems with this:

  1. It says "ABP: Disable on $domain" - how is the user supposed to know what "ABP" is? We don't mention that anywhere.
  2. For me at least, the item is never visible without scrolling, even when there would be sufficient space for the menu to grow a little. That's probably why I thought it's not there.

comment:4 Changed on 04/25/2015 at 06:48:34 PM by fhd

  • Description modified (diff)
  • Summary changed from Menu entry to whitelist the current site is not showing up to Better menu item for whitelisting the current site
  • Type changed from defect to change

I believe we need to do something about this - turned this into a change and updated summary/description accordingly.

comment:5 Changed on 04/25/2015 at 06:48:51 PM by fhd

  • Owner set to fhd

comment:6 Changed on 04/25/2015 at 06:50:53 PM by fhd

  • Description modified (diff)
  • Summary changed from Better menu item for whitelisting the current site to Improve menu item for whitelisting the current site

comment:7 Changed on 04/25/2015 at 09:46:53 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed on 05/06/2015 at 07:29:24 AM by fhd

  • Milestone set to Flux-next

comment:9 Changed on 05/06/2015 at 05:00:41 PM by fhd

  • Description modified (diff)

comment:10 Changed on 05/06/2015 at 05:00:50 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:12 Changed on 05/22/2015 at 09:34:46 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/9300e5888862

comment:13 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.