Opened on 04/21/2015 at 09:02:54 AM

Closed on 06/09/2015 at 11:11:03 AM

#2367 closed change (fixed)

[Move notification display logic to Core] Use a notification show listener in Firefox

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: 2015q2
Cc: Blocked By: #2420
Blocking: #2366 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5256408131960832/ (Same as for #2420, tackled them together)

Description (last modified by fhd)

Background

See #2366.

What to change

Instead of showing notifications three minutes after startup, register a notification show listener (provided by #2420) and show notifications only when that one is triggered.

Attachments (0)

Change History (11)

comment:1 Changed on 04/21/2015 at 09:05:43 AM by fhd

  • Blocking 2366 added

comment:2 Changed on 04/21/2015 at 09:11:57 AM by fhd

  • Keywords 2015q2 added

comment:3 Changed on 04/22/2015 at 09:20:43 AM by fhd

  • Description modified (diff)

comment:4 Changed on 04/22/2015 at 09:25:09 AM by fhd

  • Blocked By 2386 added

comment:5 Changed on 04/22/2015 at 09:44:08 AM by fhd

  • Description modified (diff)

comment:6 Changed on 04/26/2015 at 09:45:13 AM by fhd

  • Blocked By 2420 added; 2386 removed
  • Description modified (diff)
  • Summary changed from [Show notifications after downloading] in Firefox to [Move notification display logic to Core] Use notification show listener in Firefox

comment:7 Changed on 04/26/2015 at 09:47:13 AM by fhd

  • Summary changed from [Move notification display logic to Core] Use notification show listener in Firefox to [Move notification display logic to Core] Use a notification show listener in Firefox

comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:9 Changed on 06/08/2015 at 10:58:17 AM by fhd

  • Owner set to fhd

comment:10 Changed on 06/08/2015 at 11:14:47 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed on 06/09/2015 at 11:11:03 AM by fhd

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed by #2420.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.