Opened on 04/22/2015 at 01:02:47 PM

Closed on 03/16/2016 at 03:14:06 PM

Last modified on 03/16/2016 at 03:14:47 PM

#2399 closed change (rejected)

Implement a content script mechanism

Reported by: trev Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2398 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

CSS property filters are going to be implemented as a content script, there is currently no mechanism to execute them in Firefox.

What to change

Add a lib/contentScripts.js module exposing a function injectScript(contentWindow, scriptUrl). The injected content script should have direct access to the page's DOM but not to its JavaScript variables. It should also have access to ext.backgroundPage.sendMessage() and ext.onMessage() API, similarly to the first-run page.

Attachments (0)

Change History (4)

comment:1 Changed on 04/22/2015 at 01:03:04 PM by trev

  • Blocking 2398 added; 2388 removed

comment:2 Changed on 04/22/2015 at 01:10:04 PM by trev

  • Blocking 2401 added

comment:3 Changed on 03/16/2016 at 03:14:06 PM by trev

  • Resolution set to rejected
  • Status changed from new to closed
  • Tester set to Unknown

In the end we decided against "proper" content scripts. Instead, we'll load the content script into our process scripts and instantiate the class for every relevant window.

comment:4 Changed on 03/16/2016 at 03:14:47 PM by trev

  • Blocking 2401 removed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.