Opened on 04/25/2015 at 01:45:48 PM
Closed on 04/28/2015 at 07:18:04 PM
Last modified on 05/18/2015 at 03:45:17 PM
#2414 closed defect (fixed)
[adblockplus.org Anwiki to CMS migration] merge_children logic in conversion script is sub-optimal
| Reported by: | kzar | Assignee: | trev |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
There appears to be a flaw in the merge_children function of the website conversion script. Translation strings are sometimes broken up by non-translatable <a> tags even though they shouldn't be.
For example look at the "Firefox Privacy Policy" link at the bottom of the pages/privacy.html page.
What to change
Debug and fix the merge_children function so that whitelisted tags such as <a> are always included in a translation string where possible. Avoid translation strings being broken up by them.
Attachments (0)
Change History (4)
comment:1 Changed on 04/28/2015 at 06:09:13 PM by trev
- Owner set to trev
comment:2 Changed on 04/28/2015 at 06:09:22 PM by trev
- Ready set
comment:3 Changed on 04/28/2015 at 07:18:04 PM by trev
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 05/18/2015 at 03:45:17 PM by Ross
- Verified working set
Fixed.
Tested by:
Checking link tags on beta.adblockplus.org and checking output after running conversion script.
cms / r44
adblockplus-website-converter / 105208883c
Fixed: https://hg.adblockplus.org/web.adblockplus.org/rev/2eebb45c7b2b