Opened on 04/27/2015 at 10:04:48 AM
Closed on 04/28/2015 at 01:09:59 PM
Last modified on 05/20/2015 at 02:22:39 PM
#2422 closed defect (incomplete)
seamonkey: lib/ui.js, line 1918: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
| Reported by: | mmokrejs | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by mapx)
Environment
seamonkey-2.33.1
AdBlock Plus version 2.6.9
How to reproduce
I compiled seamonkey-2.33.1 with DEBUG output and it print out to STD{OUT,ERR} lots of messages while browsing. This is related to AdBlock Plus actually (version 2.6.9).
Observed behaviour
jar:file:///home/mmokrejs/.mozilla/seamonkey/mjpwg8sv.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///home/mmokrejs/.mozilla/seamonkey/mjpwg8sv.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/ui.js, line 1918: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
Original report at https://bugzilla.mozilla.org/show_bug.cgi?id=1158524
Attachments (0)
Change History (4)
comment:1 Changed on 04/27/2015 at 12:55:31 PM by mapx
- Description modified (diff)
- Summary changed from lib/ui.js, line 1918: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function to seamonkey: lib/ui.js, line 1918: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
comment:2 Changed on 04/28/2015 at 10:16:33 AM by mapx
- Cc trev greiner added
comment:3 Changed on 04/28/2015 at 01:09:59 PM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Resolution set to incomplete
- Status changed from new to closed
comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
While I can see how that would be an issue in strict mode - we currently don't enable strict mode for our code, for the very reason that the code isn't entirely compliant with it.
I verified that there is no such error if you just run SeaMonkey 2.33.1 by regular means, not even if javascript.options.strict preference is enabled. So this is merely a warning, one that currently has no relevance for Adblock Plus. Resolving as incomplete, feel free to reopen if there is a reason why this issue needs to be addressed.