Opened on 04/29/2015 at 11:57:56 AM
Closed on 05/21/2015 at 03:16:04 PM
Last modified on 05/21/2015 at 03:23:58 PM
#2433 closed change (fixed)
Add promotional image to the Adblock Browser beta launch landing page
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | annlee@… | Blocked By: | #2213 |
| Blocking: | #2436 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6357168420814848/ |
||
Description (last modified by saroyanm)
Background
In #2213 we have created a landing page for Adblock Browser beta launch, but we still need promotional image for that.
What to change
Add promotional image from the attachment to the page Adblock Browser Beta landing page:
<meta property="og:image" content="">
Attachments (1)
Change History (12)
comment:2 Changed on 04/29/2015 at 12:06:04 PM by saroyanm
- Blocked By 2213 added
comment:4 Changed on 04/29/2015 at 12:39:13 PM by saroyanm
- Status changed from new to reviewing
comment:5 Changed on 04/29/2015 at 01:55:07 PM by saroyanm
- Blocking 2436 added
comment:7 in reply to: ↑ 6 Changed on 04/29/2015 at 02:22:30 PM by saroyanm
- Cc annlee@… added
Replying to greiner:
Is this image meant to be english-only or do we intend to translate it or let others translate it into more languages?
Well I don't think that make sense to put that much effort in translation, we will need to have separate image for each translation and I consider that translatable title and description should be enough.
But definitely make sense to update ticket with new image.
Changed on 04/29/2015 at 02:23:15 PM by saroyanm
Adblock Browser Beta promo image
comment:8 follow-up: ↓ 9 Changed on 05/11/2015 at 07:21:55 PM by Ross
The image is present in the directory and the meta tag appears in the page correctly. The only thing I noticed is that it is hardcoded to http://adblockplus.org instead of a relative URL like everything else (which is 10.10.10.10 in the VM).
It's not really possible to test if social networks pull the correct image, as they can't see the VM used for testing.
Tested with:
| IE | 8.0.6001 | Windows XP |
| IE | 11.0.9600 | Windows 8.1 |
| Chrome | 42.0.2311.135 | Windows 8.1 |
| Opera | 29.0.1795.47 | Windows 8.1 |
| Firefox | 37.0.2 | Windows 8.1 |
| Chrome | 42.0.3211.111 | Android 4.2.2 |
comment:9 in reply to: ↑ 8 Changed on 05/12/2015 at 10:32:16 AM by saroyanm
Replying to Ross:
The only thing I noticed is that it is hardcoded to http://adblockplus.org instead of a relative URL like everything else (which is 10.10.10.10 in the VM).
I think it's Okey, I can't find official documentation where it mentions that og:image can be relative, but people usually using absolute url for og:image I think it's because of some social networks crawlers, that want the og:image URL be absolute. So I think it's better to keep it absolute.
It's not really possible to test if social networks pull the correct image, as they can't see the VM used for testing.
Should be Okey.
comment:10 Changed on 05/21/2015 at 03:16:04 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 05/21/2015 at 03:23:58 PM by saroyanm
- Sensitive unset
Is this image meant to be english-only or do we intend to translate it or let others translate it into more languages?