Opened on 04/30/2015 at 07:38:05 PM

Closed on 05/08/2015 at 01:51:38 PM

#2443 closed change (fixed)

ensure_dependencies.py should honour SKIP_DEPENDENCY_UPDATES env variable

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian, fhd, trev Blocked By:
Blocking: #2445 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5652679430766592/

Description (last modified by kzar)

Background

The ensure_dependencies.py script is included in a lot of our repositories, it is usually set to automatically refresh all dependencies every time build scripts are run. In some situations it would be useful to manually disable this, so that dependencies are not refreshed automatically.

What to change

Add a check for the SKIP_DEPENDENCY_UPDATES environment variable to the ensure_dependencies.py script in the buildtools repository. If present the script should simply display warnings instead of checking out revisions or cloning repositories.

Attachments (0)

Change History (8)

comment:1 Changed on 04/30/2015 at 08:08:36 PM by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 04/30/2015 at 08:24:14 PM by fhd

  • Cc fhd added

comment:3 Changed on 04/30/2015 at 09:47:03 PM by trev

  • Cc trev added

comment:4 Changed on 05/01/2015 at 09:55:08 AM by kzar

  • Description modified (diff)

comment:5 Changed on 05/01/2015 at 10:04:56 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 05/02/2015 at 01:12:00 AM by matze

  • Blocking 2445 added

comment:7 Changed on 05/07/2015 at 02:45:12 PM by kzar

  • Description modified (diff)
  • Summary changed from ensure_dependencies.py should honour SKIP_ENSURE_DEPENDENCIES env variable to ensure_dependencies.py should honour SKIP_DEPENDENCY_UPDATES env variable

comment:8 Changed on 05/08/2015 at 01:51:38 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.