Opened on 05/04/2015 at 08:39:13 PM

Closed on 05/06/2015 at 04:50:29 PM

Last modified on 05/15/2015 at 03:29:56 AM

#2452 closed defect (fixed)

[cms] \n in a translatable string is being converted into an actual line break

Reported by: trev Assignee: kzar
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kzar Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5172705124941824/

Description (last modified by kzar)

How to reproduce

Add the following code to a Markdown page:

{{string This is a line break <code><fix>\n</fix></code>}}

Observed behaviour

The following code is generated:

This is a line break <code>
</code>

Expected behaviour

The fixed string isn't interpreted:

This is a line break <code>\n</code>

Notes

Also see s40 in filters.html:
{{s40 Convert all line breaks to Unix style (replace <code><fix>\r</fix></code> by <code><fix>\n</fix></code> if present).}}

Attachments (0)

Change History (6)

comment:1 Changed on 05/05/2015 at 01:56:15 PM by kzar

  • Owner set to kzar

comment:2 Changed on 05/06/2015 at 02:57:42 PM by kzar

  • Description modified (diff)

comment:3 Changed on 05/06/2015 at 04:01:58 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/06/2015 at 04:50:29 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/07/2015 at 11:55:54 AM by kzar

comment:6 Changed on 05/15/2015 at 03:29:56 AM by Ross

  • Verified working set

Fixed.

Tested by:
Adding provided example to a CMS page and checking the output.

cms / r42

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.