Opened on 05/15/2015 at 12:24:37 PM
Closed on 05/15/2015 at 12:55:00 PM
Last modified on 05/18/2015 at 11:13:06 AM
#2529 closed defect (duplicate)
ABP logo overlaps header links in some RTL languages
Reported by: | Ross | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | kzar, saroyanm | Blocked By: | |
Blocking: | #2035 | Platform: | Unknown |
Ready: | no | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Environment
Chrome / 42.0.2311.135 (But any browser)
How to reproduce
- Visit https://beta.adblockplus.org/de/
- Observe the ABP logo does not overlap header links.
- Select the language drop-down and select the first entry (Arabic).
- Observe the ABP logo overlaps the header links.
Observed behaviour
The ABP logo overlaps the installation header link when the site is displayed in Arabic (see attached screenshots).
Note: This does not currently occur on the live site (adblockplus.org)
Expected behaviour
The ABP logo should not overlap links in the header.
Attachments (2)
Change History (5)
Note: See
TracTickets for help on using
tickets.
I can reproduce this, it's caused by the extra English flags next to the menu links. I actually think the way the new site behaves is better here though, the links in question _will_ default to English when clicked and I guess the old system wasn't smart enough to detect that.
I don't think this has anything to do with RTL, just the fact that most pages don't have translations for the language.
So really this is a duplicate of #2304 and not a blocker for the migration.