Opened on 05/18/2015 at 02:48:45 PM
Closed on 08/29/2019 at 06:00:39 PM
#2539 closed change (rejected)
Move VCS abstraction part of ensure_dependencies into a separate module
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We have some VCS abstraction code in ensure_dependencies.py for Mercurial and Git. It would be nice to reuse that elsewhere, e.g. in packager.getBuildNum(). However, ensure_dependencies.py shouldn't be imported from since it isn't really a module.
What to change
Turn ensure_dependencies.py into a real module and move the VCS abstraction into a separate module. Make sure that the ensure_dependencies.py script generated in the repository combines all the dependent modules however and can be used stand-alone.
Attachments (0)
Change History (5)
comment:1 Changed on 05/18/2015 at 03:02:28 PM by sebastian
- Component changed from Unknown to Build-and-Release-Tools
- Priority changed from Unknown to P4
- Ready set
comment:2 Changed on 05/18/2015 at 03:27:33 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/11/2017 at 03:23:34 PM by trev
- Status changed from reviewing to reopened
- Tester set to Unknown
comment:4 Changed on 04/11/2017 at 03:23:58 PM by trev
- Owner trev deleted
comment:5 Changed on 08/29/2019 at 06:00:39 PM by sebastian
- Resolution set to rejected
- Status changed from reopened to closed
Rejecting this issue now as buildtools is in maintenance mode and will eventually be discontinued.
Note: See
TracTickets for help on using
tickets.
Unassigning, I am not working on this.