Opened on 05/18/2015 at 02:45:15 PM
Closed on 05/18/2015 at 03:19:44 PM
#2538 closed change (fixed)
Register onHeadersReceived event listener only for main_frame/sub_frame
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The onHeadersReceived event listener immediately returns if called for a type of request other than main_frame or sub_frame. However, you can limit the event listener to given request types when registering, that Chrome doesn't even need to call back to JavaScript.
What to change
Remove the check for the request type from the onHeadersReceived event listener, and limit the listener to main_frame and sub_frame when registering.
Attachments (0)
Change History (2)
comment:1 Changed on 05/18/2015 at 02:46:24 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/18/2015 at 03:19:44 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/a3c2e854affe