Opened on 05/18/2015 at 06:59:44 PM

Closed on 05/19/2015 at 04:18:58 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2544 closed defect (fixed)

Documentation generation fails for Diagnostics

Reported by: trev Assignee: trev
Priority: P2 Milestone: Diagnostics-1.3-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6061584040329216/

Description

How to reproduce

Run build.py docs testdir in the abpwatcher directory.

Observed behaviour

Error message:

ERROR: Unable to parse abpwatcher/lib/main.js: Line 55: Unexpected identifier

Expected behaviour

Code documentation is generated without any errors

Attachments (0)

Change History (3)

comment:1 Changed on 05/18/2015 at 07:02:15 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/19/2015 at 04:18:58 PM by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/abpwatcher/rev/0e8d9d819f01

comment:3 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.