Opened on 05/18/2015 at 07:37:38 PM

Closed on 05/19/2015 at 04:19:35 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2549 closed defect (fixed)

Documentation generation fails for URL Fixer

Reported by: trev Assignee: trev
Priority: P2 Milestone: URL-Fixer-4.1.1
Module: URL-Fixer Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6695604965081088/

Description

How to reproduce

Run build.py docs testdir in the urlfixer directory.

Observed behaviour

Error messages:

ERROR: Unable to parse urlfixer/lib/typoAppIntegration.js: Line 38: Unexpected token true
ERROR: Unable to parse urlfixer/lib/typoFixer.js: Line 230: Unexpected identifier
ERROR: Unable to parse urlfixer/lib/typoRules.js: Line 35: Unexpected identifier

Expected behaviour

Code documentation is generated without any errors

Attachments (0)

Change History (3)

comment:1 Changed on 05/18/2015 at 07:47:01 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/19/2015 at 04:19:35 PM by trev

  • Milestone set to URL-Fixer-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/urlfixer/rev/2a1b23106507

comment:3 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.