Opened on 05/20/2015 at 12:39:35 PM

Closed on 06/10/2015 at 05:56:55 AM

#2559 closed change (fixed)

[cms] Detect conflicting pages in the development server

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5746511145074688

Description

Background

Following scenarios, currently, cause issues during pages generation, but aren't visible during development:

  • Conflicting pages of different format
    • pages/foo.md
    • pages/foo.tmpl
  • Pages conflicting with directories
    • pages/foo.tmpl
    • pages/foo/bar.tmpl
  • Pages conflicting with localizable files
    • locales/en/foo
    • pages/foo.tmpl

Currently, the development server simply returns the first match in case of a conflict.

What to change

Make the development server raise an exception, if the requested page corresponds to multiple files, or when page generation would fail due to pages conflicting with directories of the same name.

Attachments (0)

Change History (2)

comment:1 Changed on 05/20/2015 at 12:40:52 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 06/10/2015 at 05:56:55 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.