Opened on 05/20/2015 at 01:32:55 PM
Closed on 05/22/2015 at 04:07:21 PM
Last modified on 06/30/2015 at 09:33:59 AM
#2561 closed defect (fixed)
Installing extensions should not be allowed until official support lands
| Reported by: | greiner | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015081632 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
CyanogenMod 11.0
Android 4.4.4
Adblock Browser 1.0.0
How to reproduce
- Open Adblock Browser
- Click on the "Adblock Plus" panel in the new tab page
- Click on the green "Install" button on adblockplus.org
Observed behaviour
The browsers asks whether the extension should be downloaded and then whether it should be installed. Affirming both questions installs the extension without any possibility of reverting that due to #2415.
Expected behaviour
In the best case we'd show a message instead explaining that extensions are not yet supported. Otherwise we should at least prevent the existing dialog from popping up.
Attachments (0)
Change History (6)
comment:1 Changed on 05/21/2015 at 04:04:35 PM by rjeschke
- Owner set to rjeschke
- Platform changed from Unknown to Android
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 05/22/2015 at 01:44:53 PM by rjeschke
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 05/22/2015 at 04:07:21 PM by rjeschke
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/26/2015 at 03:30:51 PM by fhd
comment:5 Changed on 05/26/2015 at 03:32:00 PM by fhd
- Milestone set to Adblock-Browser-for-Android-next
Note: See
TracTickets for help on using
tickets.
Was pushed as: https://bitbucket.org/adblockplus/adblockbrowser/commits/0475a1f78c78