Opened on 05/20/2015 at 03:49:54 PM

Closed on 06/10/2015 at 05:57:28 AM

#2563 closed change (fixed)

[cms] Cache filters and globals during page generation

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5703725486178304

Description

Background

Currently, the CMS loads the modules in the filters and globals directories again everytime when processing a page with the TemplateConverter (jinja2). This is great for the development environment, as it allows to see changes immediately.

However, this is currently massively slowing down page generation for adblockplus.org, mostly because the in memory caching implemented for the get_browser_versions() global doen't have any effect if the module is reloaded every time the page is generated (for another language).

What to change

Cache the dynamically loaded filters and globals during page generation.

Attachments (0)

Change History (2)

comment:1 Changed on 05/20/2015 at 03:51:13 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 06/10/2015 at 05:57:28 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/cms/rev/9cda40a42496

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.