Opened on 05/27/2015 at 02:40:09 PM
Closed on 02/10/2016 at 04:17:31 PM
Last modified on 02/24/2016 at 12:41:20 PM
#2595 closed change (fixed)
[Move core logic into adblockpluscore repository] Add adblockpluscore dependency to adblockplus
| Reported by: | kzar | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7.2-for-Firefox |
| Module: | Core | Keywords: | |
| Cc: | fhd | Blocked By: | #2594, #3618, #3621 |
| Blocking: | #2593 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Once we have successfully moved the core logic from adblockplus to adblockpluscore #2594 we need to add adblockpluscore as a dependency to the adblockplus repository.
What to change
Add adblockpluscore as a dependency of the adblockplus repository and ensure required core code is included.
Attachments (0)
Change History (8)
comment:1 Changed on 05/27/2015 at 02:47:49 PM by kzar
- Blocked By 2594 added
comment:2 Changed on 02/04/2016 at 11:56:55 AM by fhd
- Owner set to fhd
- Tester set to Unknown
comment:3 Changed on 02/04/2016 at 12:00:03 PM by fhd
- Priority changed from Unknown to P2
comment:4 Changed on 02/04/2016 at 12:17:18 PM by fhd
- Blocked By 3618, 3621 added
comment:5 Changed on 02/04/2016 at 06:40:23 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 02/04/2016 at 08:14:13 PM by fhd
comment:7 Changed on 02/10/2016 at 04:17:31 PM by fhd
- Milestone set to Adblock-Plus-for-Firefox-next
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 02/24/2016 at 12:41:20 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Marking verified as changes have not caused any adverse effects / ABP is still working as expected.
ABP 2.7.2
Firefox 38.0 / Firefox 46.0a1 (Nightly) / Ubuntu 14.04 x64
Firefox 38.0 / Firefox 43.0.1 / Firefox 46.0a1 (Nightly) / Windows 7 x64
Note: See
TracTickets for help on using
tickets.
The change made it through review, but I won't land it before the blocking issues have landed, otherwise we mess up docs generation.