Opened on 06/05/2015 at 03:48:10 PM
Closed on 06/08/2015 at 09:59:29 AM
#2656 closed defect (fixed)
Regression: Notification not shown in icon popup
| Reported by: | greiner | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Chrome
Adblock Plus 1.8.12.1440
Background
#2642 moved the notification code into a separate module and thereby also removed the activeNotification variable from the background page's global namespace which notification.js accesses in popup.html to determine whether the notification box should be displayed in the icon popup.
What to change
Expose the data of the currently active notification to the icon popup again.
Attachments (0)
Change History (4)
comment:1 Changed on 06/05/2015 at 04:32:27 PM by sebastian
- Owner set to sebastian
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 06/05/2015 at 04:36:45 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 06/08/2015 at 09:59:29 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/3d884f200b51