Opened on 06/08/2015 at 04:38:20 PM
Closed on 06/08/2015 at 07:17:21 PM
Last modified on 06/08/2015 at 09:15:02 PM
#2664 closed change (fixed)
Remove ignoreHeaders argument from parseFilter(s) and move the logic to the UI
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P4 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
Module: | Platform | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sebastian)
Background
After #2658, trev suggested - and I agree - to also get rid of the ignoreHeaders argument in favor of slightly more complex data structures, leaving the handling of that case to the UI code.
What to change
- Replace the error string by an error object, with a toString() method, and a type property in order to distinguish unexpected filter list headers from other reasons a filter is considered invalid.
- Remove the ignoreHeaders argument from parseFilter() and parseFilters().
- Make parseFilters() return an array of errors like {filters: [..], errors: [..]} instead of bailing out on the first validation error.
- Adjust UI code and tests.
Hints for testers
Make sure that filter validation still works as it did before. See 2658#Hintsfortesters for detailed instructions.
Also pay particular attention to the handling of filter list headers. For example, if you enter [Adblock Plus 2.0] in raw edit mode on the options page, that line should simply be stripped. However, if you attempt to add that string using the single-line text field at the top, you should get an error message.
Attachments (0)
Change History (4)
comment:1 Changed on 06/08/2015 at 04:39:25 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/08/2015 at 07:17:21 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/adblockpluschrome/rev/35b96cf12609