Opened on 06/12/2015 at 04:47:53 PM
Closed on 07/30/2015 at 09:33:49 AM
Last modified on 04/21/2016 at 04:17:40 PM
#2677 closed change (fixed)
Don't bundle subscriptions.xml
| Reported by: | fhd | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | #2706 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
We're currently bundling the subscriptions.xml file in the adblockplusui repository, mainly because we're not yet sure if and how we need to change its format to have all the relevant meta data about recommended subscriptions.
What to change
We shouldn't bundle subscriptions.xml in the adblockplusui repository - the host repository is already bundling it, we can access it from there. We still need a dummy file for the test environment, however.
We should mention this requirement in the README.
Attachments (0)
Change History (10)
comment:1 Changed on 06/22/2015 at 11:58:42 AM by saroyanm
- Blocking 2706 added
comment:2 Changed on 06/22/2015 at 12:39:45 PM by greiner
- Cc greiner added
- Description modified (diff)
- Type changed from defect to change
comment:4 in reply to: ↑ 3 Changed on 06/24/2015 at 08:15:15 AM by greiner
Replying to fhd:
This was filed as a defect deliberately. Discussed it with Philip beforehand: If we don't know _what_ to do about it, just that there's a problem, it should be a defect, not a change.
Sounds reasonable but I don't think it applies here because the "what to change" section and even the title mention what to do about it. Note that the ticket description doesn't describe a problem which is why I also changed the description headlines.
comment:5 Changed on 06/24/2015 at 11:32:46 AM by fhd
I initially suspected that we also have to do something with subscriptions2.xml here, but I've looked into that today and the only thing we're interested in is really subscriptions.xml, fetched from the host application, as the description says. So yeah, I agree, makes more sense as a change.
comment:6 Changed on 07/29/2015 at 04:21:02 PM by greiner
- Owner set to greiner
- Tester set to Unknown
comment:7 Changed on 07/29/2015 at 04:38:05 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 07/30/2015 at 09:33:49 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 04/21/2016 at 03:55:51 PM by matze
- Blocking 3966 added
comment:10 Changed on 04/21/2016 at 04:17:40 PM by matze
- Blocking 3966 removed
This was filed as a defect deliberately. Discussed it with Philip beforehand: If we don't know _what_ to do about it, just that there's a problem, it should be a defect, not a change.