Opened on 04/07/2014 at 11:33:00 AM

Closed on 01/18/2018 at 09:39:19 PM

Last modified on 01/30/2018 at 06:51:59 PM

#268 closed change (fixed)

Remove cssfx.js and empty.css hack from adblockplus.org

Reported by: fhd Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29670669/

Description (last modified by juliandoucette)

Background

empty.css is a hack that made things work in IE8 in the past.

What to change

This hack is no longer necessary because we have removed all uses of features that this "hack" enabled.

Attachments (0)

Change History (14)

comment:1 Changed on 09/17/2014 at 05:14:12 PM by saroyanm

  • Component changed from Infrastructure to Websites
  • Platform set to Unknown

comment:2 Changed on 12/02/2016 at 07:50:40 PM by juliandoucette

  • Keywords goodfirstbug added
  • Tester set to Unknown

comment:3 Changed on 09/04/2017 at 05:26:04 PM by juliandoucette

  • Priority changed from P4 to P5

Reprioritizing because of ABP.org redesign.

comment:4 Changed on 09/04/2017 at 05:26:23 PM by juliandoucette

  • Sensitive unset

comment:5 Changed on 09/20/2017 at 04:20:29 PM by juliandoucette

Note: I think that [cssFx is the wrong approach in the first place, this hack is no longer needed to meet our browser requirements].

comment:6 Changed on 09/20/2017 at 04:28:17 PM by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 12/05/2017 at 04:21:34 PM by juliandoucette

  • Cc ire wspee added
  • Milestone set to adblockplus.org 2.1 index page
  • Priority changed from P5 to P3
  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened

comment:8 Changed on 01/16/2018 at 11:31:49 PM by juliandoucette

  • Owner set to juliandoucette

comment:9 Changed on 01/16/2018 at 11:36:21 PM by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:10 Changed on 01/17/2018 at 02:54:30 PM by juliandoucette

  • Description modified (diff)

comment:11 Changed on 01/18/2018 at 04:48:29 PM by juliandoucette

  • Summary changed from [adblockplus.org] Try to defer cssfx.js to avoid the empty.css IE8 hack to Remove cssfx.js and empty.css hack from adblockplus.org

comment:12 Changed on 01/18/2018 at 09:38:06 PM by abpbot

A commit referencing this issue has landed:
​Issue 268 - Removed cssfx and empty.css dependency

comment:13 Changed on 01/18/2018 at 09:39:19 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed on 01/30/2018 at 06:51:59 PM by juliandoucette

  • Milestone adblockplus.org 2.1 index page deleted

Milestone adblockplus.org 2.1 index page deleted

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.