Opened on 06/17/2015 at 02:09:36 PM
Closed on 11/10/2017 at 11:15:18 AM
#2692 closed defect (rejected)
Mouseover tooltip on ABP logo shows incorrect number for custom filters.
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by philll)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-34
Environment
Windows + 7 64bit + Firefox + English
ABP version 2.6.4
How to reproduce
- Install ABP on firefox.
- Create custom filters groups and filters.
- Uncheck all filters and custom filter groups
- Mouseover the ABP logo on firefox toolbar
Observed behaviour
Status message is saying 1 custom filters in use
Expected behaviour
Status message should say 0 custom filters in use
Attachments (1)
Change History (7)
Changed on 06/17/2015 at 02:09:40 PM by passbrains
comment:1 Changed on 06/17/2015 at 02:09:42 PM by passbrains
comment:2 follow-up: ↓ 3 Changed on 06/17/2015 at 03:51:36 PM by philll
- Description modified (diff)
#10 - 17 Jun 2015 14:22:28 posted by Tamara Blasco
Please note that, after trying to reproduce your issue, we have also noticed something that needs changing in our UI and which is related to what you reported.
A suggestion could be that every time a filter group is disabled, the different filters that form that group were disabled as well instead of having to be unmarked individually.
comment:3 in reply to: ↑ 2 Changed on 06/22/2015 at 05:39:28 PM by greiner
Replying to philll:
#10 - 17 Jun 2015 14:22:28 posted by Tamara Blasco
Please note that, after trying to reproduce your issue, we have also noticed something that needs changing in our UI and which is related to what you reported.
A suggestion could be that every time a filter group is disabled, the different filters that form that group were disabled as well instead of having to be unmarked individually.
That would lead to some unexpected behavior if the same filter is in different filter groups because if you disable a filter it will be disabled globally. Therefore if you disable all filters in a filter group those filters will also be disabled in any other filter group.
comment:4 Changed on 06/22/2015 at 05:40:41 PM by greiner
- Cc greiner added
comment:5 Changed on 09/24/2017 at 09:13:56 PM by sebastian
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Tester set to Unknown
comment:6 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
1 - 10 Sep 2014 09:09:08 posted by Deepak Koul
A file was deleted: abp1.png
2 - 01 Oct 2014 12:56:09 posted by Thomas Greiner
I suspect that a filter in one of the three disabled custom groups is enabled because that's the only way how I was able to reproduce this. Could you please check that?