Opened on 06/18/2015 at 03:43:28 PM
Closed on 03/21/2016 at 12:39:32 PM
#2694 closed defect (fixed)
Wrong order of parameters `source, target` in logging message
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
git commit: efa6615083333908f938dfe03fee37ce030ae9f5
https://github.com/adblockplus/buildtools/blob/efa6615083333908f938dfe03fee37ce030ae9f5/ensure_dependencies.py#L307
How to reproduce
- Call it when the script needs to be updated
Observed behaviour
INFO: Updating .\adblockplus\buildtools\ensure_dependencies.py from ./ensure_dependencies.py, don't forget to commit
Expected behaviour
INFO: Updating ./ensure_dependencies.py from .\adblockplus\buildtools\ensure_dependencies.py, don't forget to commit
What to change
Swap source and target to make them conform with the textual description.
Attachments (0)
Change History (8)
comment:1 Changed on 06/18/2015 at 03:51:10 PM by sebastian
- Cc kzar added
- Keywords goodfirstbug added
- Priority changed from Unknown to P4
- Ready set
comment:3 Changed on 06/18/2015 at 04:07:25 PM by sebastian
I think he were merely referring to the code line, and didn't bother the particular commit.
Anyway, I put you in CC in case you feel like fixing this. Otherwise, I leave it as goodfirstbug for new contributors, or whoever is going to get annoyed enough by this to fix it. ;)
comment:4 Changed on 06/18/2015 at 04:10:06 PM by kzar
Arg sorry, the irrelevant commit hash linked is for Sebastian's commit not mine. I was confused by GitHub's interface, it showed my name and details of a commit at the top, which was the latest commit for the file in question. Confusing! Either way I see what you both mean, and I agree it's a goodfirstbug.
comment:5 in reply to: ↑ 2 Changed on 06/18/2015 at 05:19:32 PM by sergz
Replying to kzar:
@sergz Any reason why the link is for my commit efa6615083333908f938dfe03fee37ce030ae9f5 instead of either HEAD or Wladimir's commit c3fcb9d9d937ff1cf79520a641a7967a5339197d?
Replying to sebastian:
I think he were merely referring to the code line, and didn't bother the particular commit.
Yes, it's merely a reference to the code line at the concrete state.
comment:6 Changed on 03/18/2016 at 01:48:10 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Tester set to Unknown
comment:7 Changed on 03/21/2016 at 12:37:50 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/c519bc096667
comment:8 Changed on 03/21/2016 at 12:39:32 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
@sergz Any reason why the link is for my commit efa6615083333908f938dfe03fee37ce030ae9f5 instead of either HEAD or Wladimir's commit c3fcb9d9d937ff1cf79520a641a7967a5339197d?